Hello Jan, I'll create the stand-alone commit. However, sending L3 packet from ptap tunnel to veth port won't work. The veth port would handle received packets as L2. I can use patch ports instead.
Best regards, Zoltan > -----Original Message----- > From: Jan Scheurich > Sent: Wednesday, July 12, 2017 8:55 AM > To: Ben Pfaff <b...@ovn.org>; Zoltán Balogh <zoltan.bal...@ericsson.com> > Cc: 'd...@openvswitch.org' <d...@openvswitch.org>; Georg Schmuecking > <georg.schmueck...@ericsson.com>; Jiri Benc > (jb...@redhat.com) <jb...@redhat.com>; Yang, Yi Y <yi.y.y...@intel.com> > Subject: RE: [PATCH 3/4] ofproto-dpif-xlate: drop L3 packets on L2 legacy port > > Yes, this is a bug fix for the merged PTAP series. It could be merged > independently from patches 1 and 2. > I'm sure it is possible to strip down the PTAP unit tests additions in this > patch to cover the fixed issue without > using decap action (e.g. by sending a L3 packet from a ptap tunnel to the > veth port)? > @Zoltan: could you perhaps create a stand-alone commit for this and keep the > remainder of the encap/decap unit tests > for v2 of this series? > Thanks, Jan > > > -----Original Message----- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Wednesday, 12 July, 2017 02:31 > > To: Zoltán Balogh <zoltan.bal...@ericsson.com> > > Cc: 'd...@openvswitch.org' <d...@openvswitch.org>; Jan Scheurich > > <jan.scheur...@ericsson.com>; Georg Schmuecking > > <georg.schmueck...@ericsson.com>; Jiri Benc (jb...@redhat.com) > > <jb...@redhat.com>; Yang, Yi Y > <yi.y.y...@intel.com> > > Subject: Re: [PATCH 3/4] ofproto-dpif-xlate: drop L3 packets on L2 legacy > > port > > > > On Fri, Jun 30, 2017 at 03:29:35PM +0000, Zoltán Balogh wrote: > > > This commit drops packet during xlate if it is a L3 packet and output port > > > packet_type is legacy_l2. It completes PTAP unit tests with: > > > > > > - Send L3 packet over patch port. > > > - Output L2/L3 packet to ports with different packet_type properties. > > > > > > Signed-off-by: Zoltán Balogh <zoltan.bal...@ericsson.com> > > > > This looks to me like a bug fix that should be applied even without > > patches 1 and 2. Is that right? I guess that the test does use the > > "decap" action--can the bug be triggered without "decap"? > > > > Thanks, > > > > Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
