On 2/19/26 2:28 AM, Rukomoinikova Aleksandra wrote: > On 18.02.2026 23:23, Dumitru Ceara wrote: >> On 2/17/26 6:58 PM, Alexandra Rukomoinikova wrote: >>> Add schema and CLI support for health checks on logical switch >>> ports by introducing a new health check table and linking it >>> from logical switch ports. Implement corresponding ovn-nbctl >>> commands to manage LSP health checks. Also extend service >>> monitoring to support the logical-switch-port type. >>> >>> Signed-off-by: Alexandra Rukomoinikova <[email protected]> >>> --- >>> v2 --> v3: fixed Dumitru's comments >>> --- >> Hi Alexandra, >> >> Thanks for the new revision! >> >> I had a few comments below but because they're relatively minor I went >> ahead and took care of them and applied the patch to main. That's true >> for the rest of the patches in the series (more details in the >> individual replies). > > > Hi! Thank you so much for the review, your time, and all fixes! I just > wanted to say I'm worried that you spent so much time on all the changes > during the review—I understand time is short right now due to branching, > but I have no problem making any fixes myself. Thanks again for everything) >
Hi Alexandra, Just in case my actions came across the wrong way: my main concern was the fact that I might not be able to review a new version before the scheduled branch date this Friday (I'm not working tomorrow). Also, the changes I made were relatively small and straightforward, otherwise I would've definitely asked for a new version. >> However, one thing this series misses is a NEWS entry announcing the new >> Health Check support for switch ports. As I couldn't decide on which >> patch of your series should include one and as I thought that it might >> be better for the author of the series to write it, I didn't add one either. >> >> I also didn't want that your feature misses the 26.03 branch date (this >> Friday). >> >> Could you please post a follow up that adds a NEWS entry? > > > Yeah, i will > Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
