On 2/18/26 00:46, Ihar Hrachyshka wrote:
On 2/14/26 8:59 AM, Frode Nordahl wrote:
External email: Use caution opening links or attachments
On 2/13/26 22:37, Ihar Hrachyshka via dev wrote:
This reduces the number of skipped tests from 181 to 39.
Signed-off-by: Ihar Hrachyshka <[email protected]>
Hello, Ihar,
Thank you for the patch.
Hi Frode, thanks for the quick reply!
---
debian/control | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index d99b483ac..4491578c8 100644
--- a/debian/control
+++ b/debian/control
@@ -19,7 +19,16 @@ Build-Depends: graphviz,
python3-twisted,
python3-zope.interface,
libunbound-dev,
- libunwind-dev
+ libunwind-dev,
+ util-linux,
+ python3-scapy,
+ tcpdump,
+ netcat-openbsd,
+ xxd,
+ iproute2,
+ arping,
+ ethtool,
+ nftables
I would rather not have build dependencies added here that are not
strictly required for compilation of the software itself.
Every dependency is a potential liability and added maintenance burden.
The quest to run more unit tests is a noble one and I'd advice you to do
this separately instead.
We do this already for the system testsuite [0][1], and there is nothing
stopping us from expanding this to the unit testsuite.
Yes, this seems preferable since tests may indeed be flaky.
Though if we believe that running integration tests shouldn't be part of
the main package build, then why do we run most of these tests today
(and skip only those that happen to depend on a non-existing tool)?
Should *all* tests move elsewhere? (Should nocheck become the default?)
Having some `make check` testsuite run as part of the build, as we do
today, is a useful litmus test.
Throughout the lifetime of any given package release several people may
need to change something that has potential side effects for any given
package.
These people may be experts in some other domain (think security updates
to libc, openssl, updates to complilres, toolchain and so on), and for
them to be able to make their change and get a quick reading of whether
they broke something somewhere else in the stack is invaluable.
So even if we don't run the full `make check` testsuite as part of the
package build, it has value.
---
Curious: you shared links to packaging files that are outside of OVN
tree. I assume they are part of official Debian/Ubuntu packaging, which
is different from the in-tree packaging. What is the relationship
between these distinct packages (in-tree vs. debian/ubuntu)? Should
these be reconciled?
For Open vSwitch (OVS) the debian/ubuntu and upstream sources were
reconciled a few cycles back [2], and since then important updates have
been synced in both directions.
At some point we even proposed running autopkgtests in the upstream OVS
CI, but there were some challenges with time spent rebuilding things
multiple times. The patch is probably useful as documentation for
understanding how this works though [3].
We have started initiatives to do the same with the Open Virtual Network
(OVN) packaging, but have yet to cross the finishing line with the work [4].
Things that complicate reconciliation of the OVN packaging is difference
in requirements for the OVS submodule and us having a desire to enable
OVN-VIF by default.
Both of these issues are possible to resolve.
For context: I'm trying to see if I can use the *in-tree* debian/ to
build custom packages for our downstream build pipeline for OVS and OVN.
I assume in-tree is a viable path, but I am not a Debian packaging
expert, so looking for best practices.
It is in everyone's interest, and particularly our shared base of end
users, that the available packages are compatible and do not impose
cross- and/or up-grade complications.
We're happy to work towards the goal reconciliation of the sources.
2:
https://patchwork.ozlabs.org/project/openvswitch/list/?series=309651&state=%2A
3:
https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/
4: https://patchwork.ozlabs.org/project/ovn/list/?series=312801&state=%2A
--
Frode Nordahl
WDYT?
0:
https://salsa.debian.org/openstack-team/third-party/ovn/-/blob/debian/sid/debian/tests/control?ref_type=heads
1:
https://salsa.debian.org/openstack-team/third-party/ovn/-/blob/debian/sid/debian/tests/run-tests.sh?ref_type=heads
--
Frode Nordahl
Standards-Version: 3.9.3
Homepage: http://www.ovn.org/
--
2.52.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
