On 3/4/26 2:24 AM, Randy Dunlap wrote: > Fix some kernel-doc warnings in openvswitch.h: > > Mark enum placeholders that are not used as "private" so that kernel-doc > comments are not needed for them. > > Correct names for 2 enum values: > Warning: include/uapi/linux/openvswitch.h:300 Excess enum value > '@OVS_VPORT_UPCALL_SUCCESS' description in 'ovs_vport_upcall_attr' > Warning: include/uapi/linux/openvswitch.h:300 Excess enum value > '@OVS_VPORT_UPCALL_FAIL' description in 'ovs_vport_upcall_attr' > > Convert one comment from "/**" kernel-doc to a plain C "/*" comment: > Warning: include/uapi/linux/openvswitch.h:638 This comment starts with > '/**', but isn't a kernel-doc comment. > * Omit attributes for notifications. > > Add more kernel-doc: > - add kernel-doc for kernel-only enums; > - add missing kernel-doc for enum ovs_datapath_attr; > - add missing kernel-doc for enum ovs_flow_attr; > - add missing kernel-doc for enum ovs_sample_attr; > - add kernel-doc for enum ovs_check_pkt_len_attr; > - add kernel-doc for enum ovs_action_attr; > - add kernel-doc for enum ovs_action_push_eth; > - add kernel-doc for enum ovs_vport_attr; > > Signed-off-by: Randy Dunlap <[email protected]> > --- > v5: fix one description (thanks, Ilya); > put periods at the end of enum short desriptions;
I don't see this change in the code. Did you not include it in the patch? It's a minor thing. Not sure it's worth a re-spin. There is also a couple checkpatch warnings for lines with 81 characters, but I'm not sure if it makes sense to wrap those. May become harder to read. Either way: Acked-by: Ilya Maximets <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
