Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, '<area>: <summary>', is over 70 characters, i.e., 84.
Subject: lib/net-proto: Create a new net-proto module for handling generic
network protocols.
WARNING: Line lacks whitespace around operator
#374 FILE: lib/net-proto.c:105:
if (ovs_scan_len(s, n, IP_SCAN_FMT"/"IP_SCAN_FMT,
WARNING: Line lacks whitespace around operator
#377 FILE: lib/net-proto.c:108:
} else if (ovs_scan_len(s, n, IP_SCAN_FMT"/%d",
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#585 FILE: lib/net-proto.c:316:
for (i=0; i<16; i++) {
ERROR: Improper whitespace around control block
#591 FILE: lib/net-proto.c:322:
for(nm = netmaskp[i]; nm; nm <<= 1) {
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#625 FILE: lib/net-proto.c:356:
for (i=0; i<16; i++) {
ERROR: Inappropriate spacing around cast
#1336 FILE: lib/net-proto.h:168:
return (((uint64_t)vlan << 48) | eth_addr_to_uint64(ea));
ERROR: Inappropriate spacing around cast
#1356 FILE: lib/net-proto.h:188:
random_bytes((uint8_t *)ea, sizeof *ea);
WARNING: Line is 80 characters long (recommended limit is 79)
#1425 FILE: lib/net-proto.h:257:
&(EA).ea[0], &(EA).ea[1], &(EA).ea[2], &(EA).ea[3], &(EA).ea[4], &(EA).ea[5]
WARNING: Line is 80 characters long (recommended limit is 79)
#2095 FILE: lib/net-proto.h:927:
uint8_t mo_flags; /* ND_RA_MANAGED_ADDRESS and ND_RA_OTHER_CONFIG flags. */
WARNING: Line is 80 characters long (recommended limit is 79)
#2118 FILE: lib/net-proto.h:950:
* Use the same struct for MLD and MLD2, naming members as the defined fields in
WARNING: Line is 80 characters long (recommended limit is 79)
#2119 FILE: lib/net-proto.h:951:
* in the corresponding version of the protocol, though they are reserved in the
WARNING: Line is 82 characters long (recommended limit is 79)
#2169 FILE: lib/net-proto.h:1001:
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01 }
} }
WARNING: Line is 81 characters long (recommended limit is 79)
#2172 FILE: lib/net-proto.h:1004:
#define IN6ADDR_ALL_ROUTERS_INIT { { { 0xff,0x02,0x00,0x00,0x00,0x00,0x00,0x00,
\
WARNING: Line is 84 characters long (recommended limit is 79)
#2173 FILE: lib/net-proto.h:1005:
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x02
} } }
ERROR: Inappropriate spacing around cast
#2305 FILE: lib/net-proto.h:1137:
((struct erspan_base_hdr *)((char *)gre_base_hdr + ERSPAN_GREHDR_LEN))
WARNING: Line is 84 characters long (recommended limit is 79)
#2589 FILE: lib/net-proto.h:1421:
PT_USE_NEXT_PROTO = PACKET_TYPE(OFPHTN_ONF, 0xfffe), /* Pseudo PT for
decap. */
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
