Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate spacing around cast
#401 FILE: lib/dp-packet.c:731:
memmove(veh, (char *)veh + VLAN_HEADER_LEN, 2 * ETH_ADDR_LEN);
ERROR: Inappropriate spacing around cast
#421 FILE: lib/dp-packet.c:751:
memmove((char *)veh + VLAN_HEADER_LEN, veh, 2 * ETH_ADDR_LEN);
ERROR: Inappropriate spacing around cast
#482 FILE: lib/dp-packet.c:812:
(l2_5 ? l2_5 : (char *)dp_packet_l3(packet)) - 2);
WARNING: Line is 88 characters long (recommended limit is 79)
ERROR: Inappropriate spacing in pointer declaration
ERROR: Inappropriate spacing around cast
WARNING: Line lacks whitespace around operator
#586 FILE: lib/dp-packet.c:916:
memmove((char*)dp_packet_data(packet) + MPLS_HLEN,
dp_packet_data(packet), len);
WARNING: Line is 80 characters long (recommended limit is 79)
#723 FILE: lib/dp-packet.c:1053:
dp_packet_prealloc_tailroom(b, 2 + ETH_HEADER_LEN + VLAN_HEADER_LEN + size);
ERROR: Inappropriate spacing around cast
#824 FILE: lib/dp-packet.c:1154:
const struct ip6_ext *ext_hdr = (struct ip6_ext *)data;
ERROR: Inappropriate spacing around cast
#837 FILE: lib/dp-packet.c:1167:
const struct ip6_rthdr *rh = (struct ip6_rthdr *)data;
ERROR: Inappropriate spacing around cast
#846 FILE: lib/dp-packet.c:1176:
const struct ip6_ext *ext_hdr = (struct ip6_ext *)data;
WARNING: Line is 81 characters long (recommended limit is 79)
#1801 FILE: lib/dp-packet.h:1547:
void packet_set_ipv4(struct dp_packet *, ovs_be32 src, ovs_be32 dst, uint8_t
tos,
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
