Hi! Looks good to me too! Thanks!
________________________________
From: Dumitru Ceara <[email protected]>
Sent: Thursday, March 19, 2026 7:49:50 PM
To: Ales Musil; [email protected]
Cc: Rukomoinikova Aleksandra
Subject: Re: [PATCH ovn 2/2] northd: Restrict external ARP request to
logical_ip for dnat_and_snat.
Внимание: ВНЕШНИЙ отправитель!
Будьте осторожны с вложениями и ссылками.
On 3/19/26 3:33 PM, Ales Musil wrote:
> The ARP request for given dnat_and_snat coming from external network
> could be processed on multiple chassis because the flows would check
> only the residency of the logical_port. This could lead to ToR
> confusion as the reply would come from multiple chassis.
>
> This also has another consequence, for gARP that would be sent as
> request. OVN would attempt to learn the gARP on multiple chassis
> which could lead to increase in SB race condition during MAC Binding
> insert.
>
> To prevent both condition restrict the check with logical_ip.
> Now the reply to request will be generated only by the chassis
> where the IP actually resides. Same goes for gARP, only the DGP
> will attempt to learn the MAC Binding.
>
> Fixes: 289b370dc621 ("northd: Fix for distributed dnat_and_snat ARP
> resolution.")
> Reported-at: https://redhat.atlassian.net/browse/FDP-3468
> Signed-off-by: Ales Musil <[email protected]>
> ---
Hi Ales,
This looks good to me, thanks!
Acked-by: Dumitru Ceara <[email protected]>
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
