Hi Ales Thanks for reviewing this.
On Wed, Apr 15, 2026 at 9:56 AM Ales Musil <[email protected]> wrote: > > > On Tue, Apr 14, 2026 at 5:23 PM Xavier Simonart via dev < > [email protected]> wrote: > >> We already had pinctrl_notify_main_thread counter, counting how many >> times main thread was notified by pinctrl. >> Through this patch, add pinctrl_notify_handler_thread, counting how >> many times handler thread is notified. >> >> Signed-off-by: Xavier Simonart <[email protected]> >> --- >> > > Hi Xaiver, > > thank you for the patch, I'm afraid this uncovered > a potential flake in "dns lookup : 1 HV, 2 LS, 2 LSPs/LS". > It failed twice throughout the series, could you please > check it out? > Yes, I saw that this morning as well. The issue is that since we no longer wake up pinctrl (more than 10 times per second in some cases), pinctrl stays asleep when there are no events such as packet_in, and the (recently received) counters are no longer properly synchronized. So I think we now need an extra, explicit, poll_timer_wait(1000). This would guarantee that pinctrl runs at least every sec, instead of, before this patch, at a rate defined by ovn-controller (i.e. sometimes very often, but maybe only through heartbeats). I'll send v2, thanks. > > controller/pinctrl.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/controller/pinctrl.c b/controller/pinctrl.c >> index 18b7b0df2..f62022361 100644 >> --- a/controller/pinctrl.c >> +++ b/controller/pinctrl.c >> @@ -389,6 +389,7 @@ COVERAGE_DEFINE(pinctrl_drop_buffered_packets_map); >> COVERAGE_DEFINE(pinctrl_drop_controller_event); >> COVERAGE_DEFINE(pinctrl_drop_put_vport_binding); >> COVERAGE_DEFINE(pinctrl_notify_main_thread); >> +COVERAGE_DEFINE(pinctrl_notify_handler_thread); >> COVERAGE_DEFINE(pinctrl_total_pin_pkts); >> >> /* DNS query statistics - thread-safe coverage counters */ >> @@ -3933,6 +3934,7 @@ pinctrl_recv(struct rconn *swconn, const struct >> ofp_header *oh, >> static void >> notify_pinctrl_handler(void) >> { >> + COVERAGE_INC(pinctrl_notify_handler_thread); >> seq_change(pinctrl_handler_seq); >> } >> >> -- >> 2.47.1 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Regards, > Ales > Thanks Xavier _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
