Re: [ovs-dev] [PATCH v3 05/11] netdev-dpdk: Change access from dev->common.xxx to common->xxx.

[Eelco Chaudron via dev]

On 1 Apr 2026, at 11:13, Eli Britstein wrote:

> Change function signatures to take struct netdev_dpdk_common instead of
> struct netdev_dpdk, and update internal accesses from dev->common.xxx to
> common->xxx. This makes these functions reusable by netdev-doca which
> also operates on netdev_dpdk_common.
>
> Signed-off-by: Eli Britstein <el...@nvidia.com>

Hi Eli,

The patch looks fine to me, however the more I think about the
macro-based type polymorphism, I feel we should not have this.  It
creates fragile dependencies and becomes hard to understand and maintain.

I would suggest moving them out of the common structure, or are there
any real reasons for not doing this?

I guess for the sw_stats we can do something like:

void netdev_dpdk_get_custom_stats(struct netdev_dpdk_common *common,
                                   void *sw_stats, size_t stats_size, ...) {
    memset(sw_stats, 0, stats_size);
}

And for the tx_q fields, they're not shared by any of the functions.

WDYT?

Cheers,

Eelco

PS: I will continue the review of this series after my PTO.

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev