Without this fix, expression a_type < b_type ? -1 : a_type > b_type
always evaluates to 0. Originally discovered with cppcheck. Signed-off-by: Dmitry Mityugov <[email protected]> --- This new version of the patch correctly specifies in the subject line that it is intended to OVN project. Hopefully, this will help the robot with sha1 information errors. lib/expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/expr.c b/lib/expr.c index 288e245c6..3c506c42c 100644 --- a/lib/expr.c +++ b/lib/expr.c @@ -2366,7 +2366,7 @@ compare_expr_sort(const void *a_, const void *b_) } enum expr_type a_type = a->expr->type; - enum expr_type b_type = a->expr->type; + enum expr_type b_type = b->expr->type; return a_type < b_type ? -1 : a_type > b_type; } else if (a->type == EXPR_T_AND || a->type == EXPR_T_OR) { size_t a_len = ovs_list_size(&a->expr->andor); -- 2.54.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
