Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#168 FILE: northd/ovn-logical-flows.7.rst:97:
``eth.src == D && outport == P && !is_chassis_resident("P") && flags.tunnel_rx
== 1``
WARNING: Line is 97 characters long (recommended limit is 79)
#701 FILE: northd/ovn-logical-flows.7.rst:630:
matches ``ct.new && ip && ip4.dst == VIP && reg1[16..23] == PROTO_NUM &&
reg1[0..15] == PORT``.
WARNING: Line is 89 characters long (recommended limit is 79)
#703 FILE: northd/ovn-logical-flows.7.rst:632:
``ct.new && ip && ip6.dst == VIP && reg1[16..23] == PROTO_NUM && reg1[0..15]
== PORT``.
WARNING: Line is 106 characters long (recommended limit is 79)
#730 FILE: northd/ovn-logical-flows.7.rst:659:
the flow matches ``ct.new && ip && ip4.dst == VIP && reg1[16..23] ==
PROTO_NUM && reg1[0..15] == PORT``.
WARNING: Line is 106 characters long (recommended limit is 79)
#732 FILE: northd/ovn-logical-flows.7.rst:661:
the flow matches ``ct.new && ip && ip6.dst == VIP && reg1[16..23] ==
PROTO_NUM && reg1[0..15] == PORT``.
WARNING: Line is 96 characters long (recommended limit is 79)
#792 FILE: northd/ovn-logical-flows.7.rst:721:
``commit_lb_aff(vip = VIP:PORT, backend = backend ip:backend port, proto = P,
timeout = T);``.
WARNING: Line is 110 characters long (recommended limit is 79)
#1212 FILE: northd/ovn-logical-flows.7.rst:1141:
inport == P && && ((arp.op == 1 && arp.spa == VIP && arp.tpa == VIP) ||
(arp.op == 2 && arp.spa == VIP))
WARNING: Line is 123 characters long (recommended limit is 79)
#1213 FILE: northd/ovn-logical-flows.7.rst:1142:
inport == P && && ((nd_ns && ip6.dst == {VIP, NS_MULTICAST_ADDR} &&
nd.target == VIP) || (nd_na && nd.target == VIP))
WARNING: Line is 92 characters long (recommended limit is 79)
#1555 FILE: northd/ovn-logical-flows.7.rst:1484:
``inport == external && eth.src == E && eth.dst == R &&
!is_chassis_resident("external")``
WARNING: Line is 86 characters long (recommended limit is 79)
#2167 FILE: northd/ovn-logical-flows.7.rst:2096:
*E*, a priority-50 flow that matches ``inport == P && (eth.mcast || eth.dst
== E``),
WARNING: Line is 109 characters long (recommended limit is 79)
#2244 FILE: northd/ovn-logical-flows.7.rst:2173:
A priority-110 flow is added which matches ``inport == P && arp.spa == S/L &&
arp.tpa == A && arp.op == 1``
WARNING: Line is 93 characters long (recommended limit is 79)
#2251 FILE: northd/ovn-logical-flows.7.rst:2180:
A priority-100 flow is added which matches ``inport == P && arp.spa == S/L &&
arp.op == 1``
WARNING: Line is 85 characters long (recommended limit is 79)
#3008 FILE: northd/ovn-logical-flows.7.rst:2937:
``ct.new && ip && ip.dst == VIP && REG_CT_PROTO == P_NUM && REG_CT_TP_DST ==
PORT``
WARNING: Line is 101 characters long (recommended limit is 79)
#3036 FILE: northd/ovn-logical-flows.7.rst:2965:
``reg9[6] == 1 && ct.new && ip && ip.dst == VIP && REG_CT_PROTO == P_NUM &&
REG_CT_TP_DST == PORT``
WARNING: Line is 96 characters long (recommended limit is 79)
#3057 FILE: northd/ovn-logical-flows.7.rst:2986:
``ct.new && !ct.rel && ip && ip.dst == VIP && REG_CT_PROTO == P_NUM &&
REG_CT_TP_DST == PORT``
WARNING: Line is 84 characters long (recommended limit is 79)
#3151 FILE: northd/ovn-logical-flows.7.rst:3080:
be replaced by ``flags.force_snat_for_dnat = 1; flags.loopback = 1;
ct_dnat(B);``.
WARNING: Line is 96 characters long (recommended limit is 79)
#3220 FILE: northd/ovn-logical-flows.7.rst:3149:
``commit_lb_aff(vip = VIP:PORT, backend = backend ip:backend port, proto = P,
timeout = T);``.
WARNING: Line is 107 characters long (recommended limit is 79)
#3236 FILE: northd/ovn-logical-flows.7.rst:3165:
``ct_commit { ct_label.ecmp_reply_eth = eth.src; ct_mark.ecmp_reply_port =
K;}; commit_ecmp_nh(); next;``
WARNING: Line is 84 characters long (recommended limit is 79)
#3651 FILE: northd/ovn-logical-flows.7.rst:3580:
``push(xxreg1); xxreg1 = ct_label; eth.dst = xxreg1[32..79]; pop(xxreg1);
next;``.
WARNING: Line is 88 characters long (recommended limit is 79)
#3810 FILE: northd/ovn-logical-flows.7.rst:3739:
``inport == LRP && outport == GW_PORT && REGBIT_PKT_LARGER &&
!REGBIT_EGRESS_LOOPBACK``,
WARNING: Line is 107 characters long (recommended limit is 79)
#4271 FILE: northd/ovn-logical-flows.7.rst:4200:
``ip && (!ct.trk || !ct.rpl) && flags.unsnat_new == 1 && outport == DGP &&
is_chassis_resident(CHASSIS)``
WARNING: Line is 101 characters long (recommended limit is 79)
#4273 FILE: northd/ovn-logical-flows.7.rst:4202:
``ip && ct.new && flags.unsnat_not_tracked == 1 && outport == DGP &&
is_chassis_resident(CHASSIS)``
WARNING: Line is 82 characters long (recommended limit is 79)
#4374 FILE: northd/ovn-logical-flows.7.rst:4303:
``sample(priority=65535, collector_set=id, obs_domain=obs_id,
obs_point=@cookie)``
Lines checked: 10484, Warnings: 23, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
