Hi Mike, Thanks for the review! > Why not just always output the bridge name? It would be more consistent and > could move the change to ofproto_unixctl_fdb_show_text. Both of these > suggested changes moves the output formatting into a single function.
Good point. I had been avoiding it for backward compatibility reasons, but folding the bridge header into the per-bridge helpers makes the caller much cleaner and gives a consistent output regardless of how many bridges are passed. I'll do that in v2 (and update the tests accordingly). Will send v2 shortly:) Thanks, Takeru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
