On 17 Apr 2026, at 18:28, Tim Rozet via dev wrote:
> When there are offload errors we see error messages that only include
> the netdev such as:
>
> 2026-03-19T19:42:43.103Z|03122|dpif_netlink(handler367)|ERR|failed to offload
> flow: Invalid argument: ovn-d2586f-0
>
> This error message lacks the flow information in order to debug why the
> flow failed to be offloaded. This then requires a user to go reproduce
> the problem and turn on debug logging to try to correlate the error to a
> flow.
>
> Pass the provider error to log_flow_put_message() for flow put failures,
> while keeping ENOSPC on the existing debug-only path. This makes the
> offload layer emit the failed flow match/actions for cases like EINVAL,
> so root-causing TC offload failures does not require enabling debug
> logging.
Hi Tim,
Sorry for the late response, got caught up with patches from others.
Looking at the change, I am not sure gating on specific error codes is
the right approach here. Would it be an option instead to include the
ufid in the existing log message? The one you quoted above and the
delete one a few lines lower?
With the ufid present, the failing flow can be looked up in the flow
dump output without needing to change the log level or include the
full match and actions inline.
What do you think?
//Eelco
[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
