Re: [ovs-dev] [PATCH v2 1/6] classifier: Avoid undefined behavior on 32-bit shift in raw_get_prefix().

[Eelco Chaudron via dev]

On 5 May 2026, at 17:59, Mike Pattrick via dev wrote:

> Shifting a 32-bit value by 32 bits is undefined behavior in C.  This patch
> adds a check in raw_get_prefix for when ofs == 0, which would cause such
> a bitshift, and returns early from that function.
>
> Found with clang analyze.
>
> Fixes: 13751fd88c4b ("Classifier: Track address prefixes.")
> Signed-off-by: Mike Pattrick <m...@redhat.com>

Thanks for following up the series with a v2!

This patch looks good to me.

Acked-by: Eelco Chaudron <echau...@redhat.com>

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev