On 6 May 2026, at 11:05, Eli Britstein wrote:

> If a previous run has failed, the cleanup was not completed.
> Kill a previous process and remove ovs-netdev and br0 devices.
>
> Fixes: 289e9f6baa7c ("tests: Add a simple DPDK rte_flow test framework.")
> Signed-off-by: Eli Britstein <[email protected]>

Hi Eli,

The autotest framework is designed so that on_exit handlers restore
all state when a test fails.  If a prior run leaves behind a stale
ovs-vswitchd, ovs-netdev, or br0, that means the failing test's
own teardown is broken.  Adding blanket cleanup at the start of
OVS_TRAFFIC_VSWITCHD_START papers over the real problem instead of
fixing it.  It also makes future teardown regressions harder to
detect, because the next test silently cleans up the mess.

If a specific test leaves stale state behind, its own on_exit or
cleanup should be fixed to handle the failure path correctly.

//Eelco

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to