On Wed, 20 May 2026 at 12:27, Ilya Maximets <[email protected]> wrote: > > I had one comment on the SIGABRT hardcoded value which I find ugly. > > This could be reverted to previous code, iow: > > > > @@ -215,10 +215,9 @@ AT_CHECK([cd $longname && $PYTHON3 > > $abs_srcdir/test-unix-socket.py ../$longname/ > > AT_CLEANUP > > > > AT_SETUP([ovs_assert]) > > -# SIGABRT + 128 > > -exit_status=134 > > -AT_CHECK([ovstest test-util -voff -vfile:info > > '-vPATTERN:file:%c|%p|%m' --log-file assert], > > - [$exit_status], [], [stderr]) > > +AT_CHECK([ovstest test-util -voff -vfile:info > > '-vPATTERN:file:%c|%p|%m' --log-file assert || kill -l $?], > > + [0], [ABRT > > +], [stderr]) > > > > AT_CHECK([sed 's/\(opened log file\) .*/\1/ > > s/|[[^|]]*: /|/ > > That looks a little nicer, indeed. > > > > > > > And we could remove a wrapper around usleep in test-rculist.c. > > But otherwise the removal looks complete to me. > > Good point, I missed this one. > > Do you want to send patches for these? Or I can do that a bit later.
I had the changes locally, so I just sent them. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
