On 5/20/26 6:25 PM, Mike Pattrick via dev wrote:
> On Tue, May 19, 2026 at 9:21 AM Timothy Redaelli via dev <
> [email protected]> wrote:
> 
>> When parsing a column fails (either ovsdb_parser_destroy() or
>> ovsdb_type_from_json() returns an error), the partially-built
>> columns shash and its ovsdb_type entries were leaked because
>> the error path only frees tables already added to the schema.
>>
>> Fix by adding columns to the schema immediately after creation,
>> so ovsdb_cs_free_schema() in the error path cleans it up along
>> with any types already parsed.
>>
>> Found by OpenScanHub Coverity (RESOURCE_LEAK).
>> Signed-off-by: Timothy Redaelli <[email protected]>
>> ---
>>
> 
> Looks good to me.
> 
> Reported-at: https://redhat.atlassian.net/browse/FDP-1814
> Acked-by: Mike Pattrick <[email protected]>

Thanks, Timothy and Mike!  I added a missing 'Fixes' tag and applied
this change.  Backported down to 3.6.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to