On Fri, Jul 14, 2017 at 10:01:08AM +0530, Numan Siddique wrote: > On Fri, Jul 14, 2017 at 5:31 AM, Ben Pfaff <b...@ovn.org> wrote: > > > On Tue, Jul 11, 2017 at 08:14:45PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique <nusid...@redhat.com> > > > > > > This patch adds a new OVN action 'put_nd_ra_opts' to support native > > > IPv6 Router Advertisement in OVN. This action can be used to respond > > > to the IPv6 Router Solicitation requests. > > > > > > ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow > > > with 'pause' flag set and the RA options stored in 'userdata' field. > > > This action is similar to 'put_dhcp_opts' and 'put_dhcpv6_opts'. > > > > > > When a valid IPv6 RS packet is received by the pinctrl module of > > > ovn-controller, it frames a new RA packet and sets the RA options > > > from the 'userdata' field and resumes the packet storing 1 in the > > > 1-bit result sub-field. If the packet is invalid, it resumes the > > > packet without any modifications storing 0 in the 1-bit result > > > sub-field. > > > > > > Eg. reg0[5] = put_nd_ra_opts(address_mode = "slaac", mtu = 1450, > > > slla = 01:02:03:04:05:06, prefix = > > aef0::/64) > > > > > > Co-authored-by: Zongkai LI <zealo...@gmail.com> > > > Signed-off-by: Zongkai LI <zealo...@gmail.com> > > > Signed-off-by: Numan Siddique <nusid...@redhat.com> > > > > Thanks for working on this. > > > > "checkpatch" reports: > > > > WARNING: Line length is >79-characters long > > #516 FILE: ovn/ovn-sb.xml:1518: > > <code><var>R</var> = put_nd_ra_opts(<var>D1</var> = > > <var>V1</var>, <var>D2</var> = <var>V2</var>, ..., <var>Dn</var> = > > <var>Vn</var>);</code> > > > > Hi Ben, I tried addressing the checkpatch warning before submitting the > patch. I was not able to address it properly. > I tried to restrict the length to 79 chars, like below > > <dt> > <code><var>R</var> = put_nd_ra_opts(<var>D1</var> = <var>V1</var>, > <var>D2</var> = <var>V2</var> ..., <var>Dn</var> = <var>Vn</var>); > </code> > </dt> > > But when I run "man ovn-sb", it is rendered like below which is kind of not > neat > > R = put_nd_ra_opts(D1 = V1, > D2 = V2 ..., Dn = Vn); Parameters: The following IPv6 ND > Router Advertisement option/value pairs as defined in RFC 4861.
You can ignore that one since the long line is important. Thanks, Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
