On Fri, Jul 14, 2017 at 12:14 PM, Han Zhou <zhou...@gmail.com> wrote:
> This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. > > The commit introduced a problem that "File exists" will be reported > when trying to open br0. > > The operation that adds eth0 to br0 while moving IP address from > eth0 to bridge internal interface br0 reproduces this issue. > > $ ip a del <ip> dev eth0; ip a add <ip> dev br0; ovs-vsctl add-port br0 > eth0 > $ ovs-dpctl show > ... > port 1: br0 (internal: open failed (File exists)) > ... > > At this point restarting OVS will result in connection lost for the > node. > > Reverting the change fixes the problem. Since adding physical interface > to OVS bridge is quite normal operation, the problem is more severe > than the original problem fixed by commit 67ac844, so revert this > before a better fix is found for the original problem. > Hi Han, I think I am seeing a similar issue here [1]. Can you please check and see if it's the same issue hit here which this patch fixes. [1] uses OVS 2.7.1 for tripleo and the upgrage job updates OVS 2.6.1 to OVS 2.7.1. The restart of openvswitch service fails and there is a crash in ovs-vswitchd. Please see the end of the log file (it's not too big). [1] - http://logs.openstack.org/91/473191/12/check/gate-tripleo-ci-centos-7-multinode-upgrades-nv/414af3c/logs/subnode-2/openvswitch/ovs-vswitchd.txt.gz https://review.openstack.org/#/c/473191/ 2017-07-14T04:14:04.229Z|00038|in_band|ERR|br-ex: failed to initialize in-band control: cannot open datapath local port br-ex (File exists) 2017-07-14T04:14:04.285Z|00002|daemon_unix|ERR|fork child died before signaling startup (killed (Segmentation fault), core dumped) 2017-07-14T04:14:04.285Z|00003|daemon_unix|EMER|could not detach from foreground session This segfault is consistent. I did 2 rechecks and I see the same issue. Thanks Numan Signed-off-by: Han Zhou <zhou...@gmail.com> > --- > lib/netdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/netdev.c b/lib/netdev.c > index 0d5fad5..e8843a8 100644 > --- a/lib/netdev.c > +++ b/lib/netdev.c > @@ -416,8 +416,6 @@ netdev_open(const char *name, const char *type, struct > netdev **netdevp) > name, type); > error = EAFNOSUPPORT; > } > - } else if (type && type[0] && strcmp(type, > netdev->netdev_class->type)) { > - error = EEXIST; > } else { > error = 0; > } > -- > 2.1.0 > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
