On 6/4/26 9:48 PM, Ales Musil via dev wrote:
> Add support for unicast compose_nd_ns that allows the caller to
> specify if the packet should be created as multicast or unicast
> to specified address.
> 
> Signed-off-by: Ales Musil <[email protected]>
> ---
> v2: Reabse on top of latest main.
>     Address Ilya's comments.
> 
> Note: This is planned to be used by OVN for MAC binding refresh,
> as that it would be nice if this could be backported.
> ---
>  lib/packets.c                | 12 ++++++++----
>  lib/packets.h                |  4 +++-
>  ofproto/ofproto-dpif-xlate.c |  2 +-
>  3 files changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/packets.c b/lib/packets.c
> index 998a73afe..493bc3024 100644
> --- a/lib/packets.c
> +++ b/lib/packets.c
> @@ -1868,17 +1868,21 @@ compose_ipv6(struct dp_packet *packet, uint8_t proto,
>  
>  /* Compose an IPv6 Neighbor Discovery Neighbor Solicitation message. */
>  void
> -compose_nd_ns(struct dp_packet *b, const struct eth_addr eth_src,
> +compose_nd_ns(struct dp_packet *b, bool multicast,
> +              const struct eth_addr eth_src, struct eth_addr eth_dst,

Thanks, Ales!  I removed the const from the eth_src for consistency
and applied the change.  Since OVN needs this and it's not a public
API, backporting seems fine.  So I did backport this down to 3.3.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to