Thanks Ilya, that makes sense. I will hold off on v2, wait for Aaron's review, and also wait for Adrian's fix to land in net-next before resending.
B.R Minxi Ilya Maximets <[email protected]> 于2026年6月6日周六 09:33写道： > On 6/6/26 1:42 AM, 侯敏熙 wrote: > > Also sending a v2 shortly > > to fix two pylint warnings that nipa flagged (+2 new warnings: missing > > docstring on mod_flow, and a %-format string). > Hi, Minxi. Thanks for working on all the test improvements, but, > please, do not send new versions just yet. Wait for Aaron's review. > > Simply re-sending the same patch with minor changes flagged by CI > creates a lot of churn and discourages people from reviewing the > series, as they don't really have time to look at version N while > there is already N+1. > > As a general suggestion, try to wait for a human review. It's hard > to define what the "good" amount of waiting time should be. But if > the number of human replies is noticeably smaller than the patch > version number, that might be a good sign to slow down a little. > > I would also suggest to wait for the Adrian's fix to be merged and > synced into net-next before sending the new version of the test to > avoid any potential mishaps. > > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
