Bleep bloop. Greetings Mairtin O'Loingsigh, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#351 FILE: ic/ovn-ic.c:1273:
SHASH_FOR_EACH(node, &old_nb_ports) {
WARNING: Line is 82 characters long (recommended limit is 79)
#390 FILE: ic/ovn-ic.c:1309:
&ts->header_.uuid,
1);
WARNING: Line is 91 characters long (recommended limit is 79)
#887 FILE: utilities/ovn-ic-nbctl.8.xml:54:
<dt>[<code>--may-exist</code>] <code>tsp-add</code> <var>switch</var>
<var>port</var>
WARNING: Line is 95 characters long (recommended limit is 79)
#888 FILE: utilities/ovn-ic-nbctl.8.xml:55:
[<var>column</var>[<code>:</code><var>key</var>]<code>=</code><var>value</var>]...</dt>
WARNING: Line is 87 characters long (recommended limit is 79)
#891 FILE: utilities/ovn-ic-nbctl.8.xml:58:
Creates a new transit switch port named <var>port</var> on
<var>switch</var>.
WARNING: Line is 85 characters long (recommended limit is 79)
#895 FILE: utilities/ovn-ic-nbctl.8.xml:62:
Transit switch ports names must be unique. Adding a duplicated name
results
WARNING: Line is 80 characters long (recommended limit is 79)
#907 FILE: utilities/ovn-ic-nbctl.8.xml:74:
<dt><code>tsp-set-addr</code> <var>port</var> [<var>address</var>]...</dt>
WARNING: Line is 99 characters long (recommended limit is 79)
#916 FILE: utilities/ovn-ic-nbctl.8.xml:83:
<dt>an Ethernet address, optionally followed by a space and one or
more IP addresses</dt>
WARNING: Line is 96 characters long (recommended limit is 79)
#927 FILE: utilities/ovn-ic-nbctl.8.xml:94:
peer <ref column="peer" table="Transit_Switch_Port"
db="OVN_IC_Northbound"/> column.
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#947 FILE: utilities/ovn-ic-nbctl.c:339:
tsp-add SWITCH PORT [COLUMN[:KEY]=VALUE]...\n\
WARNING: Line lacks whitespace around operator
#949 FILE: utilities/ovn-ic-nbctl.c:341:
tsp-set-addr PORT ADDRESS...\n\
WARNING: Line lacks whitespace around operator
#951 FILE: utilities/ovn-ic-nbctl.c:343:
tsp-del PORT delete a transit switch PORT\n\
Lines checked: 1327, Warnings: 13, Errors: 1
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
