On 7/13/17, 3:19 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" 
<ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote:

    On Wed, Jul 05, 2017 at 09:32:23PM -0700, Darrell Ball wrote:
    > Both ipv4 and ipv6 are supported. Also, NAT support is included.
    > 
    > Signed-off-by: Darrell Ball <dlu...@gmail.com>
    
    Thanks for adding TFTP support!
    
    The new is_tftp_ctl() function is very similar to is_ftp_ctl().  I
    suggest factoring out the common code. 

Done

 Also, please write
            ntohs(uh->udp_dst) == CT_IPPORT_TFTP
    as
            uh->udp_dst == htons(CT_IPPORT_TFTP)
    to match our common practice.

Done

    
    Thanks,
    
    Ben.
    _______________________________________________
    dev mailing list
    d...@openvswitch.org
    
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=9c4SIjTm0FSAj_H8NqdiJ_ev-2pC-f8yh5GImq31jQc&s=chDGxKSlcNUUZI1vTsll2lL9efA3RfYPUMqSY22mWgw&e=
 
    

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to