There is no guarantee that the read value d is non-zero. Also, there is no
check for whether buffer_hz equals zero after buffer_hz = d;, which could
lead to a division by zero. Therefore, instead of:
C

if (!a || !b || !c) {
    VLOG_WARN("%s: invalid scheduler parameters", fn);
    goto exit;
}

we should change it to:

C

if (!a || !b || !c || !d) {
    VLOG_WARN("%s: invalid scheduler parameters", fn);
    goto exit;
}
 from author name :<BMSTU>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to