On 6/30/26 10:14 PM, Dumitru Ceara wrote: > Hi Lorenzo, Ilya, > > Thanks for the patch and review! > > On 6/30/26 3:53 PM, Ilya Maximets wrote: >> On 6/30/26 3:17 PM, Lorenzo Bianconi wrote: >>> Always use sb_table_set_req_mon_condition macro in update_sb_monitors >>> routine even for optional tables (e.g. advertised_mac_binding or >>> advertised_route) since OvS IDL layer will take care of creating proper >>> monitor requests according to the real db schema. >> >> This will only be true after we move submodule to the current ovs/main. >> Before that the change is not safe to apply. >> > > Is there any reason why we're not bumping the submodule in this patch?
The OVS main branch should be in a good shape, so there is no reason not to bump the submodule. But it should probbably be a separate patch (in a set, or just a separate patch) as there are few things that will need adjustment due to changes in OVS code. There is a route dump API change (it now requires providing family), so OVN will need to dump IPv4 and IPv6 routes separately. There is a change in the compose_nd_ns() function prototype. And we'll need to remove the ignoring of the 'left allocated' warnings from the tests as that bug is supposed to be fixed now. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
