On 6/24/26 5:45 PM, David Marchand wrote: > dp-packet batches can hold only a fixed count of packets since their > introduction. > > This limitation makes it impossible to split packets/emit more than > the batch size during the processing of one batch. > > This series proposes to dynamically grow those batches when a > NETDEV_MAX_BURST threshold is reached. >
Thanks, David for the update! I went over the patches and they look good to me in general. I left a few small comments. One large thing left is that I remembered that af-xdp code actually relies on the batches to be bounded by 32 on transmit. This is because we're getting umem elements into a fixed size elems_pop array on the stack. We need to adjust that code to be able to handle larger batches, probably by just calling the function multiple times as you did for the recirculation. But if there are better options, would also be nice. Maybe a dynamic allocation only for the large batch case is not too bad... ? free_afxdp_buf_batch() should also push elements as the array fills in. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
