On 7/7/26 3:53 PM, Xavier Simonart via dev wrote: > Using ofport_request can make the test flaky, as OVS might have > already used the requested ofport (typically when ovn created > ovn-hv[0-9]-0 ports). In that case, it takes some time (between > a few msec to multiple seconds) until the requested ofport is > obtained. OVN handles this properly (flows are recalculated), but > tests do not handle this properly (e.g. if it happens when comparing > I-P and recompute flows). > > This patch removes ofport-request when the ofport values are unused. > When ofport itself is used in the test (e.g. when checking flows), > then ofport-request is still used, but with a value outside of the > usual ranges used by ovs and ovs. > > Signed-off-by: Xavier Simonart <[email protected]> > --- > v2: - Updated per Ilya's review i.e. still use ofport-request when needed, > instead of finding the ofport. > - Rebased on origin/main, and remove new ofport-request. > ---
Hi Xavier, Ilya, Thanks for the patch and for the reviews! > > @@ -41274,10 +40992,11 @@ wait_for_ports_up lsp1 > wait_for_ports_up sw0-port1.1 > wait_column "$hv2_uuid" Port_Binding chassis logical_port=lsp1 > > -OVS_WAIT_FOR_OUTPUT([as hv2 ovs-ofctl dump-flows br-int > table=OFTABLE_PHY_TO_LOG |grep priority=150|grep dl_vlan=7| grep -c > in_port=8], [0],[dnl > +as hv2 ovs-ofctl dump-flows br-int table=OFTABLE_PHY_TO_LOG |grep > priority=150|grep dl_vlan=7| grep in_port Nit: leftover. > +OVS_WAIT_FOR_OUTPUT([as hv2 ovs-ofctl dump-flows br-int > table=OFTABLE_PHY_TO_LOG |grep priority=150|grep dl_vlan=7| grep -c > in_port=1008], [0],[dnl > 1 > ]) > -OVS_WAIT_FOR_OUTPUT([as hv1 ovs-ofctl dump-flows br-int > table=OFTABLE_PHY_TO_LOG |grep priority=150|grep dl_vlan=7| grep -c > in_port=8], [0],[dnl > +OVS_WAIT_FOR_OUTPUT([as hv1 ovs-ofctl dump-flows br-int > table=OFTABLE_PHY_TO_LOG |grep priority=150|grep dl_vlan=7| grep -c > in_port=1008], [0],[dnl > 1 > ]) > The rest looks good to me, thanks! Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
