On 7/15/26 1:17 PM, Dmitry Mityugov wrote: > On Wed, Jul 15, 2026 at 1:54 PM Eelco Chaudron <[email protected]> wrote: >> >> >> >> On 13 Jul 2026, at 19:44, Dmitry Mityugov wrote: >> >>> The original code produced (with Python 3.14.6 and earlier versions): >>> >>> DeprecationWarning: 'count' is passed as positional argument >>> >>> This patch fixes it. >>> >>> Signed-off-by: Dmitry Mityugov <[email protected]> >> >> Thanks Dmitry for fixing this, as the named parameter exists since 3.0 >> we should be good with our supported 3.7 minimal version. >> >> The subject should be more descriptive, i.e., less general, so I would >> suggest something like: >> >> build-aux/extract-ofp-actions: Fix re.sub() DeprecationWarning. >> >> Also the commit message could be a more accurate, like; >> >> Python 3.12 deprecated passing 'count' as a positional argument to >> re.sub(). Fix this by using the keyword form instead. >> >> We can apply this during commit. The rest looks good to me. >> >> Acked-by: Eelco Chaudron <[email protected]> > > Hi Eelco, > > Thank you for the feedback, the proposed changes look good to me.
Thanks, Dmitry and Eelco! I adjusted the commit message and applied the patch. Also backported down to 3.3. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
