On 7/15/26 11:07 PM, Ilya Maximets wrote: > On 7/15/26 5:26 PM, Eelco Chaudron via dev wrote: >> >> >> On 15 Jul 2026, at 16:43, Fei Wang via dev wrote: >> >>> Fix a Coverity INTEGER_OVERFLOW warning in dpctl_dump_flows(). >>> >>> The PMD ID is stored as an unsigned, where UINT32_MAX is used as a >>> sentinel value (NON_PMD_CORE_ID). Avoid assigning it directly to an >>> int, which may trigger an implementation-defined conversion and cause >>> Coverity to report an INTEGER_OVERFLOW warning. >>> >>> Validate negative values explicitly before converting to unsigned, >>> preserving the existing behavior while eliminating the warning. >>> >>> Signed-off-by: Fei Wang <[email protected]> >> >> Hi Fei, >> >> Thanks for the new revision. It looks like you missed the comment >> about the reverse Christmas tree formatting, but I think we should >> be able to make that change when the patch is committed. >> >> With that, >> >> Acked-by: Eelco Chaudron [email protected] > > Thanks, Fei and Eelco! I fixed the declaration order and applied > the change. It wasn't strictly necessary to backport, but I was > backporting other changes and took this along down to 3.3.
I also changed the subject prefix from 'lib' to a more specific 'dpctl'. > > Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
