On 7/15/26 7:38 PM, Takeru Hayasaka wrote:
> Previously fdb/show required exactly one bridge argument. This change
> lets it accept several bridge names in a single call, and show all
> bridges when no argument is given. This reduces the number of unixctl
> round-trips for clients that poll FDB entries across many bridges
> (e.g. EVPN agents managing multiple VNIs), while still allowing a
> client to query only the subset of bridges it cares about.
>
> When more than one bridge is shown, the entries are grouped under a
> "Bridge" column, sized to the widest bridge name shown, that prints
> each bridge name only on its first row; a bridge with no entries is
> listed as a name-only row so it stays visible. JSON output is now an
> object keyed by bridge name whose values are arrays of that bridge's
> entries, e.g. {"br0": [...], "br1": [...]}; this replaces the bare
> entries array previously returned for a single bridge. The "port"
> column in the text output is renamed to "Port" so that all column
> names are capitalized; apart from that, single-bridge text output is
> unchanged.
>
> Signed-off-by: Takeru Hayasaka <[email protected]>
> ---
> v5:
> - Renamed 'name_width' to 'br_width' to avoid confusion with the port
> names used inside the function.
> - The "no such bridge" error now includes the offending bridge name.
> - Dropped the intermediate 'len' variable; strlen() is now passed
> directly to MAX().
> - Widened the "Bridge" column by one so that all column names in the
> header are separated by at least two spaces.
> - Renamed the "port" column to "Port" so that all column names are
> capitalized; adjusted existing tests (including tests/stp.at) and
> NEWS accordingly.
> (All of the above suggested by Ilya Maximets.)
Some tests are using 'grep -v port' and that's why CI failed on this
version of the patch. I fixed that by replacing 'port' with 'Port'
and applied the change.
Thanks!
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
