On Fri, Jul 14, 2017 at 09:26:36PM -0400, Russell Bryant wrote: > On Fri, Jul 14, 2017 at 4:46 AM, Timothy M. Redaelli > <tredae...@redhat.com> wrote: > > On 07/13/2017 07:21 PM, Ben Pfaff wrote: > >> On Thu, Jul 13, 2017 at 04:29:33PM +0200, Timothy Redaelli wrote: > >>> test_snprintf function (tests/test-util.c) tests snprintf with shorter > >>> length, > >>> but this emit a warning on GCC 7.0 or later. > >>> > >>> This commit disables that warning on tests only. > >>> > >>> Signed-off-by: Timothy Redaelli <tredae...@redhat.com> > >> > >> How about disabling it just for those lines of code? > > > > Good idea, it's surely better to limit the portion of disabled warning > > in order to maximize the effectiveness of the warning itself. > > > > LGTM > > Oops, I applied the original version of this patch from patchwork > before seeing Ben's alternative. > > Patchwork turned Ben's reply into a patch on patchwork instead of > associating it with the original, so I missed it.
Yeah, that's a feature of patchwork with mixed results. > I'll squash a revert of the original into Ben's patch here and apply that, > too. Sounds good. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
