On 7/28/26 5:30 PM, David Marchand wrote: > On Tue, 28 Jul 2026 at 16:43, Mike Pattrick <[email protected]> wrote: >> >> On Tue, Jul 28, 2026 at 2:39 AM David Marchand <[email protected]> >> wrote: >>> >>> None of the tests below actually do TSO as part of their checks. >>> >>> Most of them were probably simple copy/pasting from actual TSO tests >>> before software fallback and tunnel full support. >>> >>> Specifically for the ping vlan over vxlan test, looking at the commit >>> that left the restriction in place, the original issue was addressed with >>> commit 4ba65112dc09 ("netdev-linux: Do not offload IP checksum."). >>> >>> Signed-off-by: David Marchand <[email protected]> >>> --- >> >> >> These do look like old macros which are no longer needed. >> >> Acked-by: Mike Pattrick <[email protected]> > > I am wondering about the remaining CHECK_SYSTEM_TSO flag. > > If the remaining tests can only work with the userspace > implementation, why not move those tests somewhere under > system-tso-testsuite.at? Ideally, we should have tests/system-tso.at and these tso-specific tests should live there. But it probably doesn't make much sense to move them around just for this.
Thanks, David, Eelco and Mike! Applied and backported down to 3.7. AFAIU, it could go further, but there is no good reason to for that at the moment. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
