This patch sent me down an interesting rabbit hole. I checked to ensure the changes to documentation were correct (they are!). In doing so, I found that the commit_ecmp_nh, chk_ecmp_nh, and chk_ecmp_nh_mac actions are never installed by northd.
I found that commit 506f7d4bcfbc3ff668cb683eb5332c821c976fe6 from August 2022 added the use of these actions to northd. Then commit 23fdc5fe43b3147538ab124d0f8fcd5d2c13ba25 in September 2023 removed the use of these actions from northd. In the latter commit, it is explicitly mentioned that the actions' implementations were still defined in lib/actions.c for the scenario where a newer ovn-controller was being used with an older ovn-northd that may still be installing those actions. Since then, we have released two LTS versions of OVN that do not use these actions. I think we are well within our rights to remove these actions' implementations from the code altogether. This is outside the scope of documentation changes. I can send a follow-up patch that removes the code and the associated documentation. In the meantime, I think it's safe for you not to bother making any updates to the documentation of these actions since they're almost certainly going to be removed from the code soon. On Fri, Aug 21, 2026 at 3:59 PM Jacob Tanenbaum via dev <[email protected]> wrote: > > Correct the syntax for commit_ecmp_nh to include the boolean for if > ipv6 and the protocol. > > Fixes: b504ea151e94 ("actions: introduce commit_ecmp_nh action") > Assisted-by: Claude Opus 4.6, Claude Code > Signed-off-by: Jacob Tanenbaum <[email protected]> > > --- > v3 - reduce number of characters in patch subject. > ensure all lines are less than 79 characters > --- > ovn-sb.xml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/ovn-sb.xml b/ovn-sb.xml > index 9b72ec170..d19c644ee 100644 > --- a/ovn-sb.xml > +++ b/ovn-sb.xml > @@ -2752,10 +2752,14 @@ tcp.flags = RST; > </p> > </dd> > > - <dt><code>commit_ecmp_nh(<var>ipv6</var>);</code></dt> > + <dt><code>commit_ecmp_nh(ipv6 = <var>V</var>, proto = <var>P</var>); > + </code></dt> > <dd> > <p> > - <b>Parameters</b>: IPv4/IPv6 traffic. > + <b>Parameters</b>: <var>V</var> is <code>true</code> > + for IPv6 traffic or <code>false</code> for IPv4. > + <var>P</var> is the IP protocol: <code>tcp</code>, > + <code>udp</code>, or <code>sctp</code>. > </p> > > <p> > -- > 2.55.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
