On 9/2/26 10:21 AM, Han Zhou wrote: >>> Han Zhou (7): >>> controller: Fix use-after-free of nexthop group members. >>> controller: Learn routes referencing a kernel nexthop object. >>> controller: Only relearn routes when a nexthop they use changes. >>> controller: Resync netlink tables after missed notifications. >>> controller: Keep the content of route notifications. >>> controller: Split route learning into reading and resolving. >>> controller: Learn routes incrementally. >> As you're kind of doing a few different things in this patch set (fixes >> + incremental learning and support for learning routes with nexthop >> objects) I was wondering if it would make sense to reorder the patches >> and post the first part as non-RFC including: >> >> - fixes >> - incremental learning support >> >> Then the second part, the RFC one, would be just essentially what you >> have in patch 2 now which depends on the OVS patch. >> >> What do you think? > Thanks for the review! >
Hi Han, > Makes sense, I will respin it that way. It is not quite a reorder though, > the incremental patches carry a few nexthop specific bits that have to move > to the second part: > > - the nhid field of 'struct ovn_route_msg', which comes from the OVS side, > - the nexthop arguments of re_nl_resolve_route(), > - the per table set of referenced nexthop ids together with > route_exchange_handle_nexthop_changes(). > > The first part then becomes the two fixes, the route notification content, > the read/resolve split and incremental learning driven by route > notifications only, none of which needs the OVS patch. > > The second part ends up as two patches rather than one: learning a route > through a nexthop id, and handling nexthop changes incrementally. > "controller: Only relearn routes when a nexthop they use changes." merges > into the former, since on top of the incremental infrastructure there is no > longer an intermediate step that recomputes route_exchange on every nexthop > change. So the split makes that part smaller as well. > > The numbers in "controller: Learn routes incrementally." were measured with > routes using nexthop ids, which needs the OVS patch, so I will measure them > again with plain routes for the first part. > Thanks a lot for doing that, it makes sense! I'll be looking forward to the new patch set. > Thanks, > Han Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
