On 8/17/26 6:18 PM, Dumitru Ceara wrote:
> Calling bare free() is not enough for complex types.
> 
> Reported-at: 
> https://mail.openvswitch.org/pipermail/ovs-dev/2026-August/435059.html
> Reported-by: Ilya Maximets <[email protected]>
> Fixes: 93fe02646664 ("ovsdb-idl: idl compound indexes implementation")
> Signed-off-by: Dumitru Ceara <[email protected]>
> ---
> NOTE: the ternary operator spacing matches that of the other ternary
> operators in the same functions.  I can post a v2 patch set with a
> second patch that fixes the spacing everywhere if maintainers request
> one but for now I decided against that.
Normally I would say "there is no need to follow a bad example", but
in this case it does look kind of weird to write it differently.
A better approach would be to replace all the manual printf calls with
a function and fix the formatting while doing that, but that's an
unrelated and a bit unnecessary refactoring.  Should be fine as is
for now.

Thanks, Dumitru!  Applied and backported down to 3.3.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to