On 26 Jul 2026, at 17:33, Eli Britstein wrote:
> From: Ariel Levkovich <[email protected]>
>
> Add a new option to build ovs with doca by specifying '--with-doca' in the
> configure line.
>
> This flag must be used along with '--with-dpdk', otherwise the configure
> step will fail.
>
> An example:
>
> ./configure --prefix=/usr --localstatedir=/var --sysconfdir=/etc \
> --with-dpdk=static --with-doca
>
> The link type follows the selected dpdk one.
See AI comment below, which seems legit.
//Eelco
commit a2372def9c ("acinclude.m4: Add '--with-doca' option.")
Author: Ariel Levkovich <[email protected]>
This patch adds DOCA support to the OVS build system, including a new
configure macro OVS_CHECK_DOCA, CI integration, OVSDB schema columns
for DOCA status, and runtime initialization.
> AC_ARG_WITH([doca],
> [AS_HELP_STRING([--with-doca],
> [Enable DOCA support (requires --with-dpdk;
> uses the same link type as DPDK. Any provided
> value is ignored.)])],
> [have_doca=true],
> [])
> [...]
> if test "$have_doca" != true; then
Can --without-doca accidentally enable DOCA here? Autoconf runs the
action-if-given callback for both --with-doca and --without-doca,
so passing --without-doca sets have_doca=true (and with_doca=no).
The guard at the if-statement only checks have_doca, so it falls
through to the DOCA enablement branch.
The DPDK macro handles this correctly:
> if test "$have_dpdk" != true || test "$with_dpdk" = no; then
The DOCA macro appears to need the same "|| test "$with_doca" = no"
disjunct to avoid treating --without-doca as --with-doca.
[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
