Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Fix all inline functions by adding ALWAYS_INLINE.

[Eelco Chaudron via dev]

On 8 Oct 2026, at 15:00, Eli Britstein via dev wrote:

> On 06/10/2026 17:30, Eelco Chaudron wrote:
>> The OVS coding style requires that static inline functions defined
>> in .c files also be decorated with ALWAYS_INLINE.  Several functions
>> in dpif-netdev.c and dpif-netdev-dpcls.c were missing this attribute.
>> Add it to every occurrence for consistency and to avoid checkpatch
>> warnings in later patches.
>
> Instead of forcing keeping inline by this attribute, won't it just be cleaner 
> to remove the 'inline'?

I included this patch, as checkpatch was complaining about the
new (and existing) inlines.  The new one I could have added
without the inline keyword.  I'm not comfortable removing the
existing entries as we have no easy way to verify the impact of
removing this from these files.

Aaron, any feedback about this?

//Eelco
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev