Hi Eelco, Thanks for the review. You're right, I forgot to update the subject and description; v3 has them fixed.
I re-ran Coverity on the new code and the INTEGER_OVERFLOW (return_value_error) report in parse_odp_action__() is gone. The nsh tests also pass. Thanks, Fei -----邮件原件----- 发件人: Eelco Chaudron <[email protected]> 发送时间: 2026年10月15日 17:35 收件人: Fei Wang <[email protected]> 抄送: [email protected] 主题: Re: [ovs-dev] [PATCH v2] odp-util: Avoid integer overflow when parsing push_nsh action. External Mail: This email originated from OUTSIDE of the organization! Do not click links, open attachments or provide ANY information unless you recognize the sender and know the content is safe. On 14 Oct 2026, at 16:20, Fei Wang via dev wrote: > In parse_odp_action__(), the value returned by > parse_odp_push_nsh_action() is incremented by one before being > returned. If it equals INT_MAX, the addition overflows, which is > undefined behavior. Reject such input with -EINVAL before doing the > addition. > > Found by Coverity (INTEGER_OVERFLOW, return_value_error). Thanks for the new revision Fei. The code looks good, but the subject and commit message might need some updating. Did you also verify it fixes the covert issues? Cheers, Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
