Hi Lucas,
I gave this patch series a look, and I didn't notice anything
seriously wrong. I love the amount of added tests! However, a major
change was committed four days after you posted this: b9809453f546
("northd: Split en_lflow into compute and sync nodes."). This makes
your patches that touch lflow handlers require rewrites. Also, since
lflows are built and synced in separate engine nodes, it means that
some of the later patches in this series may need to be rethought or
dropped. en-lflow doesn't need to concern itself with how datapath
groups any longer. en-lflow only builds lflow_refs, and a separate
engine node takes all of the changed lflow_refs and syncs them all
together.
On Mon, Sep 28, 2026 at 10:44 AM Lucas Vargas Dias via dev
<[email protected]> wrote:
>
> This series extends northd's incremental processing so that several more
> Northbound changes are handled without falling back to a full recompute
> of the en_lflow engine node.
>
> Today only plain VIF and remote logical switch ports are processed
> incrementally; creating/deleting a logical switch, a logical router port,
> or a router/virtual/localport switch port all force a full recompute.
> This series closes those gaps, one port/datapath type at a time, and
> fixes two latent bugs in the lflow and group-ecmp-route machinery that
> only surface once datapaths and ports start being created/deleted
> incrementally.
>
> The general approach in each patch is the same: enable the incremental
> path only where the port/datapath is safe to handle self-contained,
> regenerate the flows that live outside the port's own lflow_ref
> explicitly, and fall back to a full recompute for the dependencies that
> this path does not (yet) keep in sync (distributed gateway ports,
> gateway routers, NAT, load balancers, static/dynamic routing, policies,
> etc.).
>
> Lucas Vargas Dias (7):
> northd: Enable incremental processing for localport ports.
> northd: Incrementally process virtual port creation and deletion.
> northd: Incrementally process logical switch ports of type "router".
> northd: Incrementally process logical router ports.
> northd: Handle dp-group bitmap length change in lflow ref nodes.
> northd: Incrementally process logical switch datapaths.
> northd: Skip redundant ls_stateful reprocessing for created switches.
>
> northd/en-group-ecmp-route.c | 29 +-
> northd/en-lflow.c | 39 +-
> northd/en-lr-stateful.c | 16 +-
> northd/en-ls-stateful.c | 7 +
> northd/en-multicast.c | 20 +
> northd/en-northd.c | 66 +-
> northd/en-sync-sb.c | 2 +
> northd/lflow-mgr.c | 22 +-
> northd/northd.c | 1393 ++++++++++++++++++++++++++++++++--
> northd/northd.h | 33 +-
> tests/ovn-northd.at | 1193 +++++++++++++++++++++++++++--
> 11 files changed, 2623 insertions(+), 197 deletions(-)
>
> --
> 2.43.0
>
>
> --
>
>
>
>
> _'Esta mensagem é direcionada apenas para os endereços constantes no
> cabeçalho inicial. Se você não está listado nos endereços constantes no
> cabeçalho, pedimos-lhe que desconsidere completamente o conteúdo dessa
> mensagem e cuja cópia, encaminhamento e/ou execução das ações citadas estão
> imediatamente anuladas e proibidas'._
>
>
> * **'Apesar do Magazine Luiza tomar
> todas as precauções razoáveis para assegurar que nenhum vírus esteja
> presente nesse e-mail, a empresa não poderá aceitar a responsabilidade por
> quaisquer perdas ou danos causados por esse e-mail ou por seus anexos'.*
>
>
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
