On 10/23/26 6:21 PM, Rukomoinikova Aleksandra wrote: > On 23.10.2026 13:52, Dumitru Ceara wrote: >> On 10/7/26 5:53 PM, Rosemarie O'Riorden via dev wrote: >>> Hi Alexandra! This change makes sense to me. Here are some minor comments. >> Hi Alexandra and Rosemarie, >> >> Thanks for the patch and review! >> >>> On 9/25/26 9:57 AM, Alexandra Rukomoinikova via dev wrote: >>>> Mirroring of type "lport" was done after ingress port security and >>>> before egress port security, so the mirror did not show the traffic >>>> that was really present on the port. For example, if a VM is >>>> compromised and sends packets with a spoofed source MAC, port security >>>> drops them and they never reach the mirror target, although this is >>>> exactly the traffic one would want to see. >>> An example could also be added for the egress case. >>> >> Alexandra, are you planning to send out a v2 with an amended commit >> message as Rosemarie suggested here? >> >> Alternatively, if you share an amended commit message I can just mangle >> the v1 myself when pushing the patch. I had a quick look right now and >> I think it's probably fine as is; there's only one minor conflict in the >> NEWS file that I can take care of myself. >> >> Rosemarie, would that work for you too? >> >> Thanks, >> Dumitru > Hi Dumitru! I missed the comment regarding the egress case in the > description, and I assumed that the change related to the fix tag—which > Rosemarie mentioned—could easily be added by the maintainers during the > merge, so I didn’t take any action. I’ll submit a new version. Sorry > about that.
Hi Alexandra, No worries, looking forward to the v2. Regards, Dumitru >>>> Mirror the traffic as close to the interface as possible, so that the >>>> mirror target sees what the port actually sends and receives. >>>> >>>> Signed-off-by: Alexandra Rukomoinikova <[email protected]> >>> Since this is basically a fix for your previous patch which added lport >>> mirroring, and thus decided the pipeline ordering, I think it would make >>> sense to add the Fixes tag: >>> >>> Fixes: 2a2fe266d09c ("northd: Added support for port mirroring in OVN >>> overlay.") >>> >>> Everything else below looks good to me, but I'm open to other input. >>> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
