On 10/23/26 7:15 AM, Rosemarie O'Riorden wrote:
> ovn-lb-benchmark.py embedded the node index directly in the last
> octet of VIP addresses (42.42.42.{i}). When more than 255 nodes
> are requested, this produces addresses like 42.42.42.256 which are
> not valid IPv4 -- octets must be in the range 0-255.
>
> Spread the node index across the third and fourth octets
> (42.42.{i >> 8}.{i & 0xff}) to support up to 65535 nodes with
> valid addresses.
>
> This is the same design as ovn-benchmark.py.
>
> Also make sure # of backends and VIPs is less than the max and greater
> than 0.
>
> Other housekeeping:
> - Rename lr-X to gw-X to match ovn-benchmark.py.
> - Use die() instead of sys.stderr.write() + sys.exit(1).
> - Add missing import of ovs.jsonrpc.
> - Remove unused seqno variable.
>
> Fixes: 4eefb6359203 ("tutorial: Add scripts to simulate node-port ovn-k8s
> services.")
> Assisted-by: Claude Sonnet 4.5, Claude Code
> Signed-off-by: Rosemarie O'Riorden <[email protected]>
> ---
> v1 -> v5:
> - Renamed gateway routers from lr-X to gw-X (and ports lr2j/j2lr to
> gw2j/j2gw) to match ovn-benchmark.py.
> - Made die() use sys.stderr.write() consistent with ovn-benchmark.py.
> - Replaced sys.stderr.write()/sys.exit(1) with die() for connection
> errors and argument validation.
> - Added minimum node count validation (>= 1), backends > 255
> validation (second IP octet overflow), and VIP bounds checking.
> - Added explicit import for ovs.jsonrpc.
> - Removed dead seqno variable.
> ---
Hi Rosemarie,
Thanks for the fix! Applied to main, 26.09 and 26.03.
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
