On Thu, Jul 27, 2017 at 10:27:18AM +0300, Roi Dayan wrote:
> Since it's an error message log it with VLOG_ERR instead of VLOG_INFO.
>
> Signed-off-by: Roi Dayan <r...@mellanox.com>
> ---
> lib/dpif-netlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index 55effd1..7b53ed5 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -972,8 +972,8 @@ dpif_netlink_rtnl_port_create_and_add(struct dpif_netlink
> *dpif,
> error = dpif_netlink_rtnl_port_create(netdev);
> if (error) {
> if (error != EOPNOTSUPP) {
> - VLOG_INFO_RL(&rl, "Failed to create %s with rtnetlink: %s",
> - netdev_get_name(netdev), ovs_strerror(error));
> + VLOG_ERR_RL(&rl, "Failed to create %s with rtnetlink: %s",
> + netdev_get_name(netdev), ovs_strerror(error));
> }
> return error;
> }
> --
> 2.7.4
I don't think this is appropriate. If creating with rtnetlink fails
we'll fall back to using the compat interface. As such, we may still
successfully create the tunnel. Maybe WARN would be more appropriate?
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
