Hi Sai and Anand, Thanks a lot for the patch. I have a few questions regarding the approach. Please see inline.
> -----Original Message----- > From: [email protected] [mailto:ovs-dev- > [email protected]] On Behalf Of Anand Kumar > Sent: Friday, August 11, 2017 11:42 PM > To: [email protected] > Subject: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code > comparison in CT lookup > > - Update the CT comparison function to compare individual fields instead of > NdisEqualMemory. [Alin Serdean] I don't like this change, especially mixing both members of union, i.e: > + (ctxKey.dst.port == entryKey.dst.port) && > + (ctxKey.dst.icmp_id == entryKey.dst.icmp_id) && Why are you trying to change via member by member comparison? > - Add in some padding for the ct_endpoint's union. [Alin Serdean] Why is this needed? Another question do we still need the 'pad' member inside ct_endpoint (https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Conntrack.h#L51) ? > - Update the Orig Tuple to use ICMP Type and Code instead of Port for ICMP [Alin Serdean] Agreed > > Co-authored-by: Sairam Venugopal <[email protected]> > Signed-off-by: Anand Kumar <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
