On 15/08/2017 20:04, Joe Stringer wrote:
On 15 August 2017 at 01:19, Paul Blakey <pa...@mellanox.com> wrote:
On 15/08/2017 00:56, Joe Stringer wrote:
On 8 August 2017 at 07:21, Roi Dayan <r...@mellanox.com> wrote:
From: Paul Blakey <pa...@mellanox.com>
<snip>
@@ -1062,7 +1422,7 @@ nl_msg_put_flower_options(struct ofpbuf *request,
struct tc_flower *flower)
nl_msg_put_flower_tunnel(request, flower);
}
- nl_msg_put_flower_acts(request, flower);
+ return 0;
}
The above snippet seems like it could be logically separate and kept
as a different patch, as it shouldn't affect behaviour at all but it
does actually introduce additional error checking. This could assist
git bisect if necessary.
We'll do that, thanks.
OK.
Looking at this again, we only changed the return from void to int
because of this change which can fail, so we can't separate this without
a commit that just always returns 0.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
