Hi Rohith Thanks for the improvement proposal and writeup.
I wonder if it possible to divide the document by pipeline stage and type somehow – like receive drops, flow processing drops and transmit drops. Flow processing drops due to xlate processing error drops, explicit openflow drop and resource exhaustion is one division by type. Maybe also by subtype, such as mbuf depletion for resource exhaustion type, too deep recursion for xlate error… It would be good if ‘Internal DP error’ had more specific errors, such as the above error cases. Would a table help here based on ‘stage’, ‘type’ and ‘subtype’ somehow; does not need to be as suggested above ? Seems you are intending this initially for the userspace datapath ? If you are maintaining stats on a PMD level as mentioned, did you consider possibly exporting this into pmd-stats-show (at least initially), maybe as an option, like verbose or extended or … ? You could separate out the implementation details to a separate later section; maybe some pseudocode or actual code for implementation discussion part. Thanks Darrell On 8/27/17, 11:17 PM, "ovs-dev-boun...@openvswitch.org on behalf of Rohith Basavaraja" <ovs-dev-boun...@openvswitch.org on behalf of rohith.basavar...@ericsson.com> wrote: Hi, Currently we are working on improving the packet drop statistics in OVS. Following link contains details of our proposal to improve packet drop statistics in OVS. https://urldefense.proofpoint.com/v2/url?u=https-3A__docs.google.com_document_d_1EtntZ8tPYr8lnbWyM385XMO8NIZ7v-2DRqBD1oPqLInb4_edit-3Fusp-3Dsharing&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=Hs45eNY7V06rCwaZy-m26uNMy8opKXvPKRbz2m8zRkA&s=Ys4O7MksFf7d-SP6egRvqvz--dn3-f6Sxe9MPdN5hdc&e= We would like to get your comments and feedback on our proposal. Also, welcome any suggestions to improve/update to our proposal. Thanks Rohith _______________________________________________ dev mailing list d...@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=Hs45eNY7V06rCwaZy-m26uNMy8opKXvPKRbz2m8zRkA&s=SXZvobpspWFLth9xPm591HqyseqNITCn1v5TG-jrzUM&e= _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev