On 9/10/17, 11:14 PM, "[email protected] on behalf of Yuanhan
Liu" <[email protected] on behalf of [email protected]> wrote:
On Fri, Sep 08, 2017 at 06:48:50PM +0200, Simon Horman wrote:
> On Tue, Sep 05, 2017 at 05:22:59PM +0800, Yuanhan Liu wrote:
> > From: Finn Christensen <[email protected]>
> >
> > AFAIK, most (if not all) NICs (including Mellanox and Intel) do not
> > support a pure MARK action. It's required to be used together with
> > some other actions, like QUEUE.
> >
> > To workaround it, retry with a queue action when first try failed.
> >
> > Moreover, some Intel's NIC (say XL710) needs the QUEUE action set
> > before the MARK action.
> >
> > Co-authored-by: Yuanhan Liu <[email protected]>
> > Signed-off-by: Finn Christensen <[email protected]>
> > Signed-off-by: Yuanhan Liu <[email protected]>
>
> This feels a bit like the tail wagging the dog.
> Is this the lowest level at which it makes sense to implement
> this logic?
>
> If so then I wonder if some sort of probing would be in order
> to avoid the cost of trying to add the flow twice to hardware
> where the queue is required.
Do you mean something like rte_flow capability query, like whether
a queue action is needed for a mark action? If so, yes, I do think
we miss an interface like this.
Note that even in this solution, the flow won't be created twice
to the hardware, because the first try would be failed.
[Darrell]
Having an api to quey capability and avoid the first try to HW
would be nice, but there are dependencies
on RTE, drivers etc and I don’t know definitive the api would be.
Also, as nics are added this capability needs to be done and state
needs to be kept in all cases.
It is an enhancement and if done should be reliable.
A separate comment is we need to document which nics need the queue
action.
Also, I think we should check errno in the present code.
--yliu
_______________________________________________
dev mailing list
[email protected]
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=71eTQnWPnndmPoDf64Z0cHyxIDvF0etl3eUy8H8xPFU&s=-54ktRZZw64tHzc56bL7yylfvkPgEOtmTS_89Cho02M&e=
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
