>Create a separate function from existing code, so the code can be reused in a >subsequent patch; no change in functionality. > >Signed-off-by: Darrell Ball <dlu...@gmail.com> >--- > lib/conntrack.c | 42 +++++++++++++++++++++++++++++------------- > 1 file changed, 29 insertions(+), 13 deletions(-) > >diff --git a/lib/conntrack.c b/lib/conntrack.c index c94bc27..2eca38d 100644 >--- a/lib/conntrack.c >+++ b/lib/conntrack.c >@@ -96,6 +96,11 @@ nat_conn_keys_lookup(struct hmap *nat_conn_keys, > const struct conn_key *key, > uint32_t basis); > >+static bool >+nat_conn_keys_insert(struct hmap *nat_conn_keys, >+ const struct conn *nat_conn, >+ uint32_t hash_basis); >+
This patch is refactoring the code with no change in functionality. Small nit (not necessarily needed) change variable name from 'hash_basis' to 'basis' to keep it consistent with other APIs in this file. LGTM Acked-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
