> -----Original Message----- > From: Kavanagh, Mark B > Sent: Friday, October 20, 2017 10:28 AM > To: Fischetti, Antonio <antonio.fische...@intel.com>; d...@openvswitch.org > Cc: Darrell Ball <dlu...@gmail.com>; Loftus, Ciara <ciara.lof...@intel.com>; > Kevin Traynor <ktray...@redhat.com>; Aaron Conole <acon...@redhat.com> > Subject: RE: [PATCH v8 4/6] netdev-dpdk: manage failure in mempool name > creation. > > >From: Fischetti, Antonio > >Sent: Thursday, October 19, 2017 5:54 PM > >To: d...@openvswitch.org > >Cc: Kavanagh, Mark B <mark.b.kavan...@intel.com>; Darrell Ball > ><dlu...@gmail.com>; Loftus, Ciara <ciara.lof...@intel.com>; Kevin Traynor > ><ktray...@redhat.com>; Aaron Conole <acon...@redhat.com>; Fischetti, Antonio > ><antonio.fische...@intel.com> > >Subject: [PATCH v8 4/6] netdev-dpdk: manage failure in mempool name creation. > > > >In case a mempool name could not be generated log a message > >and return a null mempool pointer to the caller. > > > >CC: Mark B Kavanagh <mark.b.kavan...@intel.com> > >CC: Darrell Ball <dlu...@gmail.com> > >CC: Ciara Loftus <ciara.lof...@intel.com> > >CC: Kevin Traynor <ktray...@redhat.com> > >CC: Aaron Conole <acon...@redhat.com> > >Fixes: d555d9bded5f ("netdev-dpdk: Create separate memory pool for each > >port.") > >Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> > >--- > > lib/netdev-dpdk.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > >diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > >index dc1e9c3..6fc6e1b 100644 > >--- a/lib/netdev-dpdk.c > >+++ b/lib/netdev-dpdk.c > >@@ -502,6 +502,9 @@ dpdk_mp_name(struct dpdk_mp *dmp) > > int ret = snprintf(mp_name, RTE_MEMPOOL_NAMESIZE, "ovs_%x_%d_%d_%u", > > h, dmp->socket_id, dmp->mtu, dmp->mp_size); > > if (ret < 0 || ret >= RTE_MEMPOOL_NAMESIZE) { > >+ VLOG_DBG("snprintf returned %d. Failed to generate a mempool " > >+ "name for \"%s\". Hash:0x%x, mtu:%d, mbufs:%u.", > >+ ret, dmp->if_name, h, dmp->mtu, dmp->mp_size); > > return NULL; > > } > > return mp_name; > >@@ -533,6 +536,10 @@ dpdk_mp_create(struct netdev_dpdk *dev, int mtu, bool > >*mp_exists) > > > > do { > > char *mp_name = dpdk_mp_name(dmp); > >+ if (!mp_name) { > >+ rte_free(dmp); > >+ return NULL; > >+ } > > > This is a fix, and as such, needs to include 'Fixes: <commit ID>" in the > commit > message. > > I believe that Kevin made the same comment on this patch in v7.
[Antonio] Actually I added Fixes: d555d9bded5f ("netdev-dpdk: Create separate... right before the Signed-off-by line. Is that what you meant? > > Thanks, > Mark > > > > > VLOG_DBG("Port %s: Requesting a mempool of %u mbufs " > > "on socket %d for %d Rx and %d Tx queues.", > >-- > >2.4.11 _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev