On Wed, Sep 06, 2017 at 10:31:28AM -0400, Lance Richardson wrote: > > From: "Mark Michelson" <[email protected]> > > To: [email protected] > > Sent: Wednesday, September 6, 2017 9:38:40 AM > > Subject: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port > > types. > > > > OVN is lenient with the types of logical switch ports. Maybe too > > lenient. This patch attempts to solve this problem on two fronts: > > > > 1) In ovn-nbctl, if you attempt to set the port type to an unknown > > type, the command will not end up setting the type. > > 2) In northd, when copying the port type from the northbound database to > > the corresponding port-binding in the southbound database, a warning > > will be issued if the port is of an unknown type. > > > > Signed-off-by: Mark Michelson <[email protected]> > > --- > > v4: > > * Fixed failing ovn-controller-vtep test that attempted to > > set a switch port type to "void" > > v3: > > * OVN_NB_LSP_TYPES declaration is static > > * northd will not copy unknown port types to southbound DB > > * re-ordered port types in OVN_NB_LSP_TYPES > > v2: > > * Used ARRAY_SIZE to calculate length of OVN_NB_LSP_TYPES > > v1: > > * Initial patch > > --- > > LGTM. > > Acked-by: Lance Richardson <[email protected]>
Thanks Mark and Lance. I applied this to master. I changed the VLOG_WARN in ovn-northd.c to VLOG_WARN_RL, so that it gets rate-limited, but I otherwise left it as is. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
