On Mon, Nov 13, 2017 at 03:20 AM GMT, Mark Michelson wrote: > This patch series adds support for sending periodic router > advertisements from OVN. The patch is divided into two commits > > * Commit 1 introduces a method to ensure that multicast packets are sent > only to targets on the local hypervisor > * Commit 2 adds the ability to actually send the periodic RAs. > > This patch series builds on the work in Numan Siddique's "ovn IPv6: Add > Router Solicitation responder support and generate Neighbor Solicitation > request for unknown" (patch series 11416 if using git-pw). Thus this > patch series cannot be merged until that patch series is merged first. > > There are a couple of points I'd like to bring up with regards to this > patch that I would like addressed in reviews: > > * I placed the logic for sending periodic RAs in pinctrl.c. My reasoning > for this was that the closest thing that exists in OVN today is the > periodic sending of gratuitous ARP requests, and that is in pinctrl.c. > If periodic sending of RAs should be placed into a separate file, > please let me know. > * In this patch, you will notice that a copy of the put_load() function > from ovn/controller/physical.c has been placed in pinctrl.c. My choice > was either to make the function public or duplicate it. Given that the > function is so small, I see no reason why it would be modified, I went > with the duplication choice. However, if it should be done the other > way, let me know and I'll go that direction instead. > > > v3 -> v4: > * Annotated default preferred lifetime and valid lifetime declarations. > * Ensure that MTU < 1280 is not advertised. > > v2 -> v3: > Updated patch 2 based on feedback from Jakub Sitnicki > * Fixed typo in ovn-nb.xml > * Fixed function declaration of ipv6_ra_config_delete > * Used ipv6_parse_cidr() instead of manually parsing > * Added comments explaining some non-obvious items. > * Made destructor of ipv6_ra_state NULL-safe > > v1 -> v2: > * The patchset has been applied on top of patch series 11416. The cover > letter above has been adjusted for that change. > * Patch 1 has been updated by adding new information to the > ovn-architecture manpage that mentions the MLF_KEEP_LOCAL flows > installed in table 32. > Mark Michelson (2): > OVN: Add multicast keep-local flag. > OVN: Add support for periodic router advertisements.
Reviewed-by: Jakub Sitnicki <[email protected]> Thanks, Jakub _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
